Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(source-klaviyo): Add API Budget #53223

Merged
merged 10 commits into from
Feb 13, 2025
Merged

feat(source-klaviyo): Add API Budget #53223

merged 10 commits into from
Feb 13, 2025

Conversation

tolik0
Copy link
Contributor

@tolik0 tolik0 commented Feb 7, 2025 •
edited
Loading

What

This PR introduces API budget tracking.
It helps manage and optimize API usage to prevent exceeding rate limits.

How

  • Updated CDK version to leverage new features and improvements.
  • Added API Budget tracking, allowing better control over API request consumption.
  • Increased default concurrent workers to 50, improving sync speed.

Review guide

User Impact

Syncs should become faster due to the increased default concurrency.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@vercel Vercel
Copy link

vercel bot commented Feb 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 10:55am

@tolik0 tolik0 self-assigned this Feb 10, 2025
@tolik0
Copy link
Contributor Author

tolik0 commented Feb 10, 2025 •
edited by github-actions bot
Loading

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (f4db8a3)

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Feb 11, 2025
@tolik0
Copy link
Contributor Author

tolik0 commented Feb 12, 2025

Removing custom record filter is blocked by: airbytehq/airbyte-python-cdk#330

@tolik0
Copy link
Contributor Author

tolik0 commented Feb 13, 2025 •
edited by github-actions bot
Loading

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (2fec089)

@tolik0
Copy link
Contributor Author

tolik0 commented Feb 13, 2025 •
edited
Loading

Regression tests:
https://github.com/airbytehq/airbyte/actions/runs/13305835587/job/37156494759
https://github.com/airbytehq/airbyte/actions/runs/13306440718/job/37158417398

@tolik0 tolik0 merged commit 0bf8b98 into master Feb 13, 2025
29 of 30 checks passed
@tolik0 tolik0 deleted the tolik0/source-klaviyo/add-api-budget branch February 13, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darynaishchenko darynaishchenko darynaishchenko approved these changes

Assignees

@tolik0 tolik0

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/klaviyo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tolik0 @darynaishchenko @octavia-squidington-iii